Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigationItem): align utils with actions and other components #6054

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(NcAppNavigationItem): align utils with actions and other components #6054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/assets/NcAppNavigationItem.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
/* counter */
.app-navigation-entry__counter-wrapper {
// Add slightly more space to the right of the counter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will change the counter space, did you test it with the counter? if it looks off?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto_20240905_160729

2 and 4 have a counter, 3 has actions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-09-05 16-39-13

I would argue it looks better now though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

If they are moved more to the right, the actions become misaligned with NcAppNavigationCaption, so unless you have any better ideas @susnux I would keep it the way it is currently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was no critic, just wanted to add screenshots for Gretas comment, I am fine with any of that :)

margin-right: calc(var(--default-grid-baseline) * 3);
margin-right: calc(var(--default-grid-baseline) * 2);
display: flex;
align-items: center;
flex: 0 1 auto;
Expand Down
Loading