Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcAppSidebar): add noToggle prop to hide the built-in toggle button #5702

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 13, 2024

☑️ Resolves

  • Allows to use open state (which is the only way to hide sidebar with v-show) without the built-in toggle button

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Add noToggle prop

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jun 13, 2024
@ShGKme ShGKme added this to the 8.13.0 milestone Jun 13, 2024
@ShGKme ShGKme requested review from susnux and Pytal June 13, 2024 12:42
@ShGKme ShGKme self-assigned this Jun 13, 2024
@susnux susnux merged commit bb79505 into master Jun 13, 2024
19 checks passed
@susnux susnux deleted the feat/NcAppSidebar--no-toggle branch June 13, 2024 17:29
@susnux
Copy link
Contributor

susnux commented Jun 13, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants