Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcCheckboxRadioSwitch): Add background color for button style #5509

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(NcCheckboxRadioSwitch): Add background color for button style #5509

merged 1 commit into from
Apr 22, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 20, 2024 •
edited
Loading

☑️ Resolves

On forms we use the button style for the views-toggle (view edit results), we noticed the background is not set to it will leak the background e.g. when scrolling.

🖼️ Screenshots

🏚️ Before 🏡 After
Screen Shot 2024-04-20 at 22 13 55 Screen Shot 2024-04-20 at 22 14 26

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux
fix(NcCheckboxRadioSwitch): Add background color for button style
3b72f6c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Apr 20, 2024
@susnux susnux added this to the 8.11.3 milestone Apr 20, 2024
@susnux susnux requested review from Pytal, ShGKme and a team April 20, 2024 20:17
@susnux
Copy link
Contributor Author

susnux commented Apr 20, 2024

/backport to next

ShGKme
ShGKme approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@susnux susnux mentioned this pull request Apr 20, 2024
Closed
szaimen
szaimen approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jerome-Herbinet
Copy link
Member

Not tested, but obviously makes sense.

@susnux susnux merged commit 715d2e3 into master Apr 22, 2024
18 checks passed
@susnux susnux deleted the fix/checkbox-background-color branch April 22, 2024 12:05
@backportbot backportbot bot mentioned this pull request Apr 22, 2024
Merged
jancborchardt
jancborchardt reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@Antreesy Antreesy mentioned this pull request May 7, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@szaimen szaimen szaimen approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.11.3
Development

Successfully merging this pull request may close these issues.

View-Switch is transparent when view is not selected
5 participants
@susnux @Jerome-Herbinet @jancborchardt @ShGKme @szaimen