-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Leftovers of name
prop migration + fix @
in user ids (richEditor)
#4222
Conversation
4e92aae
to
23c8ab6
Compare
@@ -51,7 +51,7 @@ export default { | |||
name: 'NcAutoCompleteResult', | |||
|
|||
props: { | |||
label: { | |||
title: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was intentional, because we agreed to use the term title
only if if relates to the HTML attribute title
, which it does not here.
Is there a deeper problem with renaming the prop here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the problem was that the property of the menububble was renamed from label to title, but the menububble and the autocompleteresult share the same data.
Also I think that in this case title is the more logical name for this property usage.
…bel` to `title` * Also fix the mixin to allow `@` within userids Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
23c8ab6
to
cb532ca
Compare
@Antreesy nice! Add the title prop :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭
☑️ Resolves
title
props and slots toname
#4106The first commit solves some issues / leftovers where the property was renamed but the example code was not changed.
The second commit solves an issues were mentioning users with
@
in there userid was not possible (@
was removed).Also added a note about the property renaming on the changelog previously only
name
->title
was mentioned and notlabel
->title
.New tests included.
🖼️ Screenshots
🏁 Checklist