NcAppNavigationCaption: Align actions with other navigation action #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
requested review from
st3iny,
raimund-schluessler,
skjnldsv,
marcoambrosini and
nimishavijay
…actions Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/align-app-navigation-caption
branch
from
5cc0663 to
261639f
Compare
| @@ -145,6 +144,8 @@ export default { | |||
| opacity: $opacity_normal; | |||
| box-shadow: none !important; | |||
| flex-shrink: 0; | |||
| // padding to align the name with the icon of app navigation items | |||
| padding: 0 calc(var(--default-grid-baseline, 4px) * 2) 0 calc(var(--default-grid-baseline, 4px) * 3); | |||
There was a problem hiding this comment.
I don't understand the syntax, why not just this?
Suggested change
| padding: 0 calc(var(--default-grid-baseline, 4px) * 2) 0 calc(var(--default-grid-baseline, 4px) * 3); | |
| padding: 0 calc(var(--default-grid-baseline) * 2) 0 calc(var(--default-grid-baseline) * 3); |
There was a problem hiding this comment.
That's the fallback in case --default-grid-baseline is not defined.
marcoambrosini
approved these changes
Jun 16, 2023
raimund-schluessler
approved these changes
Jun 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist