fix toggle overlapping other stuff #4134
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
added
bug
|
/backport to stable7 |
There was a problem hiding this comment.
LGTM after a fast test :
Capture vidéo du 17-05-2023 14:10:04.webm
May some other reviewers test it ?
|
if this is the result we want, then works for me too |
I would tend to say that the collapse button should be on the very right: Minor reordering of the elements would make this work. |
Can you submit a patch? I am not sure where to adjust this... |
I can try, but I don't have a dev environment at hand right now. |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Should work now. See the enhanced example in the docs. I didn't test it in an app though. |
Thanks a lot! :) |
| //shows the triangle button | ||
| // hides the triangle button | ||
| .icon-collapse { | ||
| visibility: hidden; | ||
| display: none; | ||
| } | ||
| &.app-navigation-entry--no-icon, | ||
| &:hover, &:focus { | ||
| a .app-navigation-entry-icon { | ||
| visibility: visible; | ||
| } | ||
| .icon-collapse { | ||
| //shows the triangle button | ||
| visibility: visible; | ||
| // shows the triangle button | ||
| display: initial; |
There was a problem hiding this comment.
I think one of this changes now reverted the idea of #4103...
There was a problem hiding this comment.
There was a problem hiding this comment.
The dropdown arrow isn't visible at the moment either. I just had to switch from visibility to display as otherwise the button takes space even if it's not visible.
I wouldn't say it's entirely unexpected. Even Google still uses this pattern in their apps sometimes (e.g. Googlemail Web). But they indeed seem to switch to an up/down arrow for open/closed state, e.g. in their expandable list view: So, how about we do this as well? Menu collapsed: arrow down, Menu open: arrow up? |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
I implemented it like this. Please have a look. |
|
The dropdown icon when collapsed is not shown permanently:
|
How about we simply show it all the time (when collapsed and open). I would find it confusing to only show it when collapsed and hide it when open. |
Yes, it should be shown all the time :) |
| .icon-collapse { | ||
| visibility: hidden; | ||
| display: none; |
There was a problem hiding this comment.
@raimund-schluessler can the above be addressed by simply setting this to display:initial?
Fix #4103 (comment)