-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add slot for description of NcEmptyContent
#3895
feat: Add slot for description of NcEmptyContent
#3895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, although I am a bit skeptical whether we should allow this much adjustments, or rather keep it consistent.
I know what you mean, maybe we should move the slot inside the And maybe the title should (have been) restricted to a prop accepting only |
I think this would be to much coding effort to restrict it. Maybe we simply give a hint in the description of the slot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with me if there's a need for this.
813be06
to
8cb61be
Compare
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
8cb61be
to
9b946d4
Compare
Rebased this and added the discussed documentation comments and moved the slot inside the paragraph element. |
/backport to stable7 |
Like the
title
this allows to override the default behavior of the description by providing a slot for it.This way you could pass in formatted content (e.g. using emphasis / strong emphasis ...).
Note: Maybe move the slot inside the paragraph element?