Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow accessible labels for NcActionInput #3517

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Allow accessible labels for NcActionInput #3517

merged 1 commit into from
Dec 16, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Nov 25, 2022 •
edited
Loading

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: input-field Covering the InputField, TextField, ... labels Nov 25, 2022
@Pytal Pytal added this to the 7.2.0 milestone Nov 25, 2022
@Pytal Pytal self-assigned this Nov 25, 2022
@Pytal Pytal mentioned this pull request Nov 25, 2022
Closed
6 tasks
@Pytal Pytal requested a review from PVince81 November 29, 2022 00:58
@Pytal
Copy link
Contributor Author

Pytal commented Dec 6, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/a11y-action-input-label branch from 569982b to 415790c Compare December 6, 2022 23:08
@Pytal Pytal force-pushed the enh/a11y-action-input-label branch from 415790c to 4f360f2 Compare December 9, 2022 02:00
@Pytal Pytal force-pushed the enh/a11y-action-input-label branch 2 times, most recently from 52d1348 to 39b2e08 Compare December 13, 2022 00:57
@marcoambrosini marcoambrosini added the 💥 breaking PR that requires a new major version label Dec 14, 2022
@Pytal
Copy link
Contributor Author

Pytal commented Dec 15, 2022 •
edited
Loading

Public API is stable, the breaking label is for the DOM structure @marcoambrosini?

Edit: Removing label, can be added back if indeed breaking

@PVince81 PVince81 requested a review from skjnldsv December 15, 2022 08:54
skjnldsv
skjnldsv approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@Pytal Pytal force-pushed the enh/a11y-action-input-label branch from 39b2e08 to 2bd0274 Compare December 16, 2022 00:46
@Pytal
Allow accessible labels for NcActionInput
2cd5946 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-action-input-label branch from 2bd0274 to 2cd5946 Compare December 16, 2022 00:50
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 💥 breaking PR that requires a new major version 3. to review Waiting for reviews labels Dec 16, 2022
@Pytal Pytal merged commit 9f0ce12 into master Dec 16, 2022
@Pytal Pytal deleted the enh/a11y-action-input-label branch December 16, 2022 00:55
@skjnldsv skjnldsv modified the milestones: 7.2.0, 7.2.1 Dec 16, 2022
@jotoeri jotoeri modified the milestones: 7.3.1, 7.3.0 Dec 23, 2022
kesselb added a commit to nextcloud/mail that referenced this pull request Feb 14, 2023
@kesselb
fix: use api to read input value
56aa8ba 
The internal dom structure was changed by nextcloud-libraries/nextcloud-vue#3517

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit to nextcloud/mail that referenced this pull request Feb 14, 2023
@kesselb
fix: use api to read input value
fcde51e 
The internal dom structure was changed by nextcloud-libraries/nextcloud-vue#3517

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this pull request Feb 14, 2023
Merged
kesselb added a commit to nextcloud/mail that referenced this pull request Feb 14, 2023
@kesselb
fix: use api to read input value
89b3f9c 
The internal dom structure was changed by nextcloud-libraries/nextcloud-vue#3517

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 left review comments

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: actions Related to the actions components feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Pytal @PVince81 @JuliaKirschenheuter @skjnldsv @marcoambrosini @jotoeri