Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new container layout #3091

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Implement new container layout #3091

merged 3 commits into from
Sep 1, 2022

Conversation

juliushaertl
Copy link
Contributor

@juliushaertl juliushaertl commented Aug 23, 2022 •
edited
Loading

Vue components implementation of nextcloud/server#33568

@juliushaertl juliushaertl added enhancement New feature or request 3. to review Waiting for reviews labels Aug 23, 2022
This was referenced Aug 26, 2022
Merged
Closed
Merged
@juliushaertl juliushaertl added the breaking PR that requires a new major version label Aug 31, 2022
@raimund-schluessler raimund-schluessler added this to the 7.0.0 milestone Aug 31, 2022
@juliushaertl
Implement new container layout
d79db57 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Add border radius
e2e2da0 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Fix app content list layout
f664314 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Contributor Author

@ChristophWurst Pushed a few more adjustments for the app content list layout that is used in mail, scrolling in general works, just the message list doesn't seem to be handled entirely by the vue components so header__button element needs some adjustments with its contents.

@juliushaertl juliushaertl mentioned this pull request Sep 1, 2022
Merged
skjnldsv
skjnldsv previously requested changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH, this is for 7.0.0

@tacruc tacruc mentioned this pull request Sep 1, 2022
Merged
@juliushaertl juliushaertl mentioned this pull request Sep 1, 2022
Merged
@juliushaertl juliushaertl dismissed skjnldsv’s stale review September 1, 2022 11:19

Branched off stable6 to move on

raimund-schluessler
raimund-schluessler approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I didn't test it. However, I guess that's what the planned beta release is for 😄

@juliushaertl juliushaertl merged commit d3fad93 into master Sep 1, 2022
@juliushaertl juliushaertl deleted the poc/redesign branch September 1, 2022 11:29
@ChristophWurst ChristophWurst mentioned this pull request Sep 1, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@PVince81 PVince81 Awaiting requested review from PVince81

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews breaking PR that requires a new major version enhancement New feature or request
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@juliushaertl @raimund-schluessler @skjnldsv @CarlSchwan