Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run eslint with webpack for vue files #2640

Closed
wants to merge 1 commit into from

Conversation

raimund-schluessler
Copy link
Contributor

This brings back running eslint on vue files when webpack runs (dev, watch, build) which got lost with #2594.

Before:
See that eslint only reports lint problems in js files when e.g. `npm run watch' runs.

After:
See that eslint now also reports lint problems in vue files when e.g. `npm run watch' runs.

@raimund-schluessler raimund-schluessler added component Component discussion and/or suggestion regression Regression of a previous working feature labels Apr 17, 2022
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added configuration Pull requests that update a config file and removed component Component discussion and/or suggestion labels Apr 17, 2022
@skjnldsv
Copy link
Contributor

So, we actually are moving away from this :)
To have those as a separate step nextcloud-libraries/webpack-vue-config#318

@raimund-schluessler
Copy link
Contributor Author

raimund-schluessler commented Apr 19, 2022

So, we actually are moving away from this :) To have those as a separate step nextcloud/webpack-vue-config#318

Hm, ok. I just found it very helpful with fixing many linting errors in #2637 to immediately only see the ones I didn't fix yet. But I guess that's an edge case. Closing then.

@raimund-schluessler raimund-schluessler deleted the fix/noid/eslint-on-watch branch April 19, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Pull requests that update a config file regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants