Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix button disable state and reactivity #2622

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Fix button disable state and reactivity #2622

merged 2 commits into from
Apr 8, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Apr 8, 2022 •
edited
Loading

  • Update documentation
  • Fix reactivity
  • Fix disabled design

Peek 08-04-2022 10-07

Fix #2621

Dark theme + different primary colour

Peek 08-04-2022 10-15

Dark theme + black primary colour

Peek 08-04-2022 10-16

Light theme + black primary colour

Peek 08-04-2022 10-18

Light theme + bright primary colour

Peek 08-04-2022 10-19

@skjnldsv
Fix button disable state and reactivity
a976859 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: button labels Apr 8, 2022
@skjnldsv skjnldsv added this to the 5.1.1 milestone Apr 8, 2022
@skjnldsv skjnldsv self-assigned this Apr 8, 2022
marcoambrosini
marcoambrosini approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing :)

@raimund-schluessler
Copy link
Contributor

Very nice! I just wonder whether we should disable the hover feedback for disabled buttons. They still look quite enabled when you hover them. 🤔

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Apr 8, 2022

Added more examples

@skjnldsv
Disable hover effect when disabled
31b86e1 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Apr 8, 2022

Very nice! I just wonder whether we should disable the hover feedback for disabled buttons. They still look quite enabled when you hover them. 🤔

Done 🚀

raimund-schluessler
raimund-schluessler approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@skjnldsv skjnldsv merged commit b936c44 into master Apr 8, 2022
@skjnldsv skjnldsv deleted the fix/buttons branch April 8, 2022 08:31
@skjnldsv skjnldsv mentioned this pull request Apr 8, 2022
Merged
@jancborchardt jancborchardt mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: button
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.

Disabled primary button unreadable
3 participants
@skjnldsv @raimund-schluessler @marcoambrosini