-
Notifications
You must be signed in to change notification settings - Fork 1
Load collections of different resources on change #816
Load collections of different resources on change #816
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
I see the same actually in deck and was wondering if we should rather adjust either deck or nextcloud-vue to only render the SidebarTabs once the tab becomes active. I could imagine that the slot for the tab is for example then only shown if active
Otherwise I don't see a clean way to delay the API call until the UI is actually visible. |
cc @skjnldsv ^ any opinion on modifying the vue lib? |
Needs to be heavily tested. One of the issue is that it will force-reload the entire tab every time you change. So you will lose a lot of snappiness. Especially for heavy tabs like Sharing 🤔 |
I would actually cover this differently. If you want to not fire all the data when the tab is not shown, you can detect and handle this by watching the You have more flexibility as a dev if you can safely manage the rendering of your tab rather than enforcing this for everyone I would say :) |
That sounds clever, let me try that. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Works |
Talk PR to test it with: nextcloud/spreed#6956 |
Please review @juliushaertl @skjnldsv @marcoambrosini |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Fix #814
While this works, it now immediately causes a request when changing a Talk room, even if the sidebar tab is not the shown one.
Anyone has an idea? @marcoambrosini @juliushaertl