Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not set vue's comments setting for dev builds #84

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 18, 2023

This might lead to unexpected behavior, for example this will break some @nextcloud/vue components like NcActionCheckbox.
Because then if you use translation comments the text will be broken.

<NcActionCheckbox>
  <!-- TRANSLATORS: Some context -->
  {{ t('foo', 'bar') }}
</NcActionCheckbox>

This will not lead to a checkbox with the text TRANSLATORS: Some context as the first VNode is the comment. This is not expected behavior. Users should set this config flag manually if needed.

@susnux susnux added bug Something isn't working 3. to review Ready to review labels Dec 18, 2023
@susnux susnux requested a review from ShGKme December 18, 2023 16:50
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (026b470) 81.69% compared to head (2b72ba6) 81.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   81.69%   81.62%   -0.07%     
==========================================
  Files           8        8              
  Lines         579      577       -2     
  Branches       48       48              
==========================================
- Hits          473      471       -2     
  Misses         58       58              
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShGKme
Copy link
Contributor

ShGKme commented Dec 18, 2023

I was sure that TRANSLATORS comments don't work in Vue Templates...

@susnux
Copy link
Contributor Author

susnux commented Dec 18, 2023

I was sure that TRANSLATORS comments don't work in Vue Templates...

They do we use them in the forms app (where I noticed this issue)

… have unexpected behavior

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/do-not-set-unexpected-config branch from 92f6547 to 2b72ba6 Compare December 18, 2023 23:45
@susnux susnux merged commit dabcb85 into main Dec 18, 2023
11 checks passed
@susnux susnux deleted the fix/do-not-set-unexpected-config branch December 18, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants