feat(app-config): Add option to override the app name #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some apps use a different name in package.json than the real app ID is. But we need the app ID, so add an option to override it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to stable1 |
ShGKme
reviewed
Jun 20, 2024
Comment on lines
-130
to
+137
| runtime: `window.OC.filePath('${appName}', '', '${filename}')`, | ||
| runtime: `window.OC.filePath('${options.appName}', '', '${filename}')`, |
There was a problem hiding this comment.
This allows us to have different names on package.json and appInfo.id. So it allows us to not rename Talk to Spreed in package.json
However, it forces us to set appName to appInfo.id, which doesn't make much sense - we can also read it from the file. So it doesn't allows us to have talk-something.js as an output.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps use a different name in package.json than the real app ID is. But we need the app ID, so add an option to override it.