Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Polyfill node core modules by default when building apps #11

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 1, 2023

Apps are built for browsers, so we should always polyfill node modules.

@susnux susnux added the 3. to review Ready to review label Aug 1, 2023
@susnux susnux requested a review from skjnldsv August 1, 2023 14:30
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/polyfill-node-modules-for-apps branch from a602dee to 54565c5 Compare August 1, 2023 14:32
@skjnldsv skjnldsv merged commit 4e7e5f5 into main Aug 1, 2023
7 checks passed
@skjnldsv skjnldsv deleted the fix/polyfill-node-modules-for-apps branch August 1, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants