Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use Vite, Vitest add ESLint and Prettier #21

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Refactor: Use Vite, Vitest add ESLint and Prettier #21

merged 6 commits into from
Jun 19, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 19, 2024

Modernize the package building to comply with our current standards

susnux added 4 commits June 19, 2024 11:15
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added the 3. to review Waiting for reviews label Jun 19, 2024
@susnux susnux requested a review from st3iny June 19, 2024 09:55
susnux added 2 commits June 19, 2024 12:10
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Comment on lines -7 to +10
- Browserslist config updates, which means some older browsers are no longer supported
- Dependency updates

- Browserslist config updates, which means some older browsers are no longer supported
- Dependency updates
Copy link
Contributor

@st3iny st3iny Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the formatting intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by prettier to align with tabwidth, lets say you want to break the line then it needs to be indented with tab width, with this change it looks like this:

- Before
    Same point
-   After
    Same point

@susnux susnux merged commit e186677 into main Jun 19, 2024
10 checks passed
@susnux susnux deleted the refactor branch June 19, 2024 10:27
@susnux susnux mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants