Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and cleanup package #602

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Fix and cleanup package #602

merged 6 commits into from
Sep 26, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 24, 2023 •
edited
Loading

  1. Fix links in README after package was moved to nextcloud-libraries
  2. Add exports field to package.json to support modern node resolution
  3. Use only vite for building, drop dependency on tsup (and migrate vite config to @nextcloud/vite-config)
  4. Fix reported eslint issues (mostly the indention of the vue file)
  5. Fix naming of the dialog component -> dialog is a reserved HTML name so rename it to PasswordDialog.
  6. Update l10n extraction script to also allow extraction from properties

@susnux
chore: Simplify build script to only use vite (and migrate to `@nextc…
ddb7135 
…loud/vite-config`)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Fix linting issues
db6e3f8 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Rename Dialog component to PasswordDialog as Dialog is a H…
7bbaffe 
…TML reserved name

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Make vue and @nextcloud/vue peer dependencies
413de79 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Use correct links after package was moved on github to `nextclou…
3045101 
…d-libraries` organization

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Sep 24, 2023
@susnux susnux requested a review from Pytal September 24, 2023 13:42
@susnux
fix: Update extract-l10n to also allow extracting strings from prop…
b2ecabb 
…erties

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit 8937616 into master Sep 26, 2023
5 checks passed
@susnux susnux deleted the chore/cleanup-package branch September 26, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @skjnldsv