Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Prepare new release #795

Merged
merged 1 commit into from
Jan 10, 2024
Merged

chore: Prepare new release #795

merged 1 commit into from
Jan 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 10, 2024

Not sure if we consider this breaking and so need 2.0.0? Or Just 1.3.0?

1.3.0- 2024-01-10

Enhancements

  • enh: Move package to vite for bundling + compress translations #781 (susnux)

Changed

  • chore(package): replace .npmignore with files array #757 (st3iny)
  • chore: Update workflows #780 (susnux)
  • fix: Adjust readme as we no longer use travis #794 (susnux)
  • Update dependencies
  • Update translations

@susnux
chore: Prepare new release
ed2734a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@raimund-schluessler
Copy link

I would be fine with 1.3.0. It didn't take any adjustments to use the package in Tasks.

@raimund-schluessler
Copy link

raimund-schluessler commented Jan 10, 2024 •
edited
Loading

Although we changed the type to module, so it might be worth a major release, just to be on the safe side.

@st3iny
Copy link
Contributor

st3iny commented Jan 10, 2024

If there are no changes required for consumers of the library, I'm also fine with 1.3.0.

st3iny
st3iny approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have "main": "dist/index.cjs" so it should be fine (with older bundlers, node versions etc.).

@susnux susnux merged commit 0161423 into master Jan 10, 2024
12 checks passed
@susnux susnux deleted the chore/release-2 branch January 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @raimund-schluessler @st3iny