Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reset method to file list filters #1116

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 13, 2024

This allows the files app to reset filters if needed (e.g. on navigation) instead all filters to listen to different events.

@susnux susnux added enhancement New feature or request 3. to review labels Nov 13, 2024
@susnux susnux requested review from artonge and skjnldsv November 13, 2024 12:08
Copy link

codecov bot commented Nov 13, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (45d7733) to head (c3f92ac).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1116   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          23       23           
  Lines         632      632           
  Branches      166      166           
=======================================
  Hits          580      580           
  Misses         45       45           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux susnux force-pushed the feat/file-list-filters-reset branch from a435b8a to 49ee626 Compare November 13, 2024 12:11
@susnux susnux mentioned this pull request Nov 13, 2024
1 task
This allows the files app to reset filters if needed (e.g. on
navigation) instead all filters to listen  to different events.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/file-list-filters-reset branch from 49ee626 to c3f92ac Compare November 13, 2024 13:47
@susnux susnux merged commit 34ba275 into main Nov 13, 2024
18 checks passed
@susnux susnux deleted the feat/file-list-filters-reset branch November 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants