Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable4] Add unittests for usables #923

Closed
wants to merge 4 commits into from
Closed

[stable4] Add unittests for usables #923

wants to merge 4 commits into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 23, 2023

Manual backport of #917

@susnux
Copy link
Contributor Author

susnux commented Aug 23, 2023

I let this open, as this might have the same problems on server as nextcloud/server#39955

@susnux susnux marked this pull request as draft August 23, 2023 10:41
@susnux susnux changed the title Add unittests for usables [stable4] Add unittests for usables Aug 23, 2023
@susnux
feat(tests): Add unit tests for FilePicker useables
028a814 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(ci): Add node test CI
94c4949 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Drop unneeded node workflow
d42489e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Update @nextcloud/files version
fcfe578 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux marked this pull request as ready for review August 25, 2023 11:27
@susnux susnux requested a review from skjnldsv August 25, 2023 11:28
@susnux susnux added dependencies Pull requests that update a dependency file 3. to review labels Aug 25, 2023
@susnux
Copy link
Contributor Author

susnux commented Aug 25, 2023

I let this open, as this might have the same problems on server as nextcloud/server#39955

Should be ok now with beta19 of files library.

@susnux
Copy link
Contributor Author

susnux commented Aug 25, 2023

Well no. We use nextcloud-vue 7 which only provides CJS entry points, those need to be converted to ESM but somehow the require('vue-material-design-icons/...') are not handled by the vue plugin but directly, so that there are invalid syntax errors.

@susnux susnux marked this pull request as draft September 13, 2023 22:04
@susnux
Copy link
Contributor Author

susnux commented Mar 6, 2024

lets not do

@susnux susnux closed this Mar 6, 2024
@susnux susnux deleted the dav-and-tests branch March 6, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@susnux