Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): adapter interface fix #8054

Merged
merged 1 commit into from
Jul 16, 2023
Merged

fix(ts): adapter interface fix #8054

merged 1 commit into from
Jul 16, 2023

Conversation

ThangHuuVu
Copy link
Member

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

Revert the TS change in Adapter to match with core & new @auth packages

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
auth-docs ⬜️ Ignored (Inspect) Jul 16, 2023 1:43pm
auth-docs-nextra ⬜️ Ignored (Inspect) Jul 16, 2023 1:43pm
next-auth-docs ⬜️ Ignored (Inspect) Jul 16, 2023 1:43pm

@ThangHuuVu ThangHuuVu changed the base branch from main to v4 July 16, 2023 13:43
@github-actions github-actions bot added providers adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` legacy Refers to `next-auth` v4. Minimal maintenance. frameworks svelte labels Jul 16, 2023
@ThangHuuVu ThangHuuVu merged commit bd37c55 into v4 Jul 16, 2023
3 checks passed
@ThangHuuVu ThangHuuVu deleted the fix/ts-adapter-interface-fix branch July 16, 2023 13:47
@balazsorban44 balazsorban44 mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz

@ndom91 ndom91 Awaiting requested review from ndom91

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` frameworks legacy Refers to `next-auth` v4. Minimal maintenance. providers svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThangHuuVu