-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apps/dev/solid-start
. Not ready for merging due to cookie esm issue; help?
#7203
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@AlexErrant is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
🚮 Removed packages: @solid-auth/next@0.0.19, solid-js@1.6.6 |
9784f29
to
37bb6eb
Compare
fa96b45
to
65aa467
Compare
Closing as this has been in draft mode for a very long time, now gathering merge conflicts. Feel free to clean it up and reopen! |
☕️ Reasoning
Nextjs and Sveltekit each have a
dev
app. Solid-Start should too!🧢 Checklist
❌Not ready for merging
pnpm dev
inapps/dev/solid-start
with thecookie
npm dependency results in the following error message:Hours of googling yielded the following related issues, none of whose solutions worked for me.
vitejs/vite#2579
jshttp/cookie#127
jshttp/cookie#87
sveltejs/kit#1113
vitejs/vite#5668
pnpm dev
works if I swapcookie
forcookie-esm
, but I feel like that PR wouldn't be merged. Seeking help/advice!