Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve maintenance #3969

Merged
merged 7 commits into from
Feb 14, 2022
Merged

chore: improve maintenance #3969

merged 7 commits into from
Feb 14, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 13, 2022

I cleaned up the following:

  • stale action: Does not link to Regarding stale issues #912 anymore. If we want to make that info more prominent, maybe the CONTRIBUTING.md file is more prominent, we should link to that instead. This PR does not address that.
  • PR labeler action: Cleaned it up and locked the version on the action to prevent future issues
  • Issue labeler action: New bot that auto triages adapter bug reports. based on the dropdown choice of the user, it will add the adapter specific issue label
  • Bug report issue template: This is our default template, should mostly be used for core-specific reports and later on (Make next-auth framework agnostic (Vite, Vue, Express...) #2294) other frameworks.
  • Bug report (Adapter): Since moving to a monorepo (Move all NextAuth.js projects into a monorepo #3952), we will need to manage adapters better. This new template asks adapter questions like a version of that adapter and provides a dropdown for the user of our available adapters (and another category for custom adapters). Used by the Issue labeler action to auto-label these with the specific adapter type to be able to scan the issues more easily.
  • Bug report (Provider): Similar to the above one, but we don't auto-label these individually since all of them are in the core.
  • default label for bug reports/feature requests is now "triage". A maintainer will need to mark something as a "bug" or "accepted" before it is considered for further investigation.
  • issues with the label "triage" won't be auto-closed
  • issues with the label "accepted" won't be auto-closed

Check the labels page for the new and existing labels: https://github.com/nextauthjs/next-auth/labels

What we could do in addition is to create PR templates specific for new providers and adapters with precise checkpoints (testing, expectations, docs, etc). This can be addressed in a subsequent PR.

@vercel
Copy link

vercel bot commented Feb 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/EmXWoeiAT4VgkKJUBPG7zo94Addp
✅ Preview: Canceled

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Great job cleaning all this up. Love the little details like the links to the docs for the various labelers, etc.

@balazsorban44 balazsorban44 merged commit 39f9473 into main Feb 14, 2022
@balazsorban44 balazsorban44 deleted the chore/maintenance-foo branch February 14, 2022 00:25
@balazsorban44
Copy link
Member Author

cc @lluia, @StefanSelfTaught, @ThangHuuVu. This hopefully will help with triaging.

mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
* chore: clean up stalebot config

* chore: introduce issue labeler bot

* chore: clean up PR labeler bot

* chore: clean up bug report process

* chore: add space

* chore: add links to docs in provider/adapter issue templates

* chore: add triage label to feature request issue template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants