Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): resize default AzureAD profile picture #2910

Merged
merged 2 commits into from
Oct 10, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Oct 7, 2021

See #2524 (comment) for the explanation.

the docs should be updated as well: https://github.com/nextauthjs/docs/issues/62

Relevant issue: #2919

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #2910 (8d1ce91) into beta (a0b9577) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #2910      +/-   ##
==========================================
- Coverage   14.16%   14.07%   -0.10%     
==========================================
  Files          85       85              
  Lines        1348     1357       +9     
  Branches      383      392       +9     
==========================================
  Hits          191      191              
- Misses       1096     1107      +11     
+ Partials       61       59       -2     
Impacted Files Coverage Δ
src/providers/azure-ad-b2c.ts 0.00% <0.00%> (ø)
src/providers/azure-ad.ts 0.00% <0.00%> (ø)
src/providers/line.js 0.00% <0.00%> (ø)
src/server/pages/error.tsx 0.00% <0.00%> (ø)
src/server/pages/signin.tsx 0.00% <0.00%> (ø)
src/server/pages/signout.tsx 0.00% <0.00%> (ø)
src/server/pages/verify-request.tsx 0.00% <0.00%> (ø)
src/server/lib/oauth/client-legacy.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b9577...8d1ce91. Read the comment docs.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balazsorban44 balazsorban44 merged commit 58a98b6 into beta Oct 10, 2021
@balazsorban44 balazsorban44 deleted the fix/azure-ad-resize-profile branch October 10, 2021 16:47
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
* Update azure-ad.js

* fix: default azure AD profile photo size

Co-authored-by: ndom91 <yo@ndo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants