Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): refactor Azure B2C provider #2862

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Sep 29, 2021

Thanks for helping out with testing this, @BenjaminWFox!

Fixed azure-ad-b2c provider config to support v4.

#2524,

Fixes #2735

Proof after signing in:

NOTE: We did not manage to set an image, but I added a comment so we can fix it in the future.

@github-actions
Copy link

🎉 Experimental release published on npm!

npm i next-auth@0.0.0-pr.2862.59712c27
yarn add next-auth@0.0.0-pr.2862.59712c27

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-commenter
Copy link

Codecov Report

Merging #2862 (488776c) into beta (f635035) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #2862      +/-   ##
==========================================
+ Coverage   14.02%   14.09%   +0.07%     
==========================================
  Files          85       85              
  Lines        1362     1355       -7     
  Branches      388      385       -3     
==========================================
  Hits          191      191              
+ Misses       1106     1102       -4     
+ Partials       65       62       -3     
Impacted Files Coverage Δ
src/providers/azure-ad-b2c.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f635035...488776c. Read the comment docs.

@balazsorban44 balazsorban44 merged commit 72d4c5b into beta Sep 29, 2021
@balazsorban44 balazsorban44 deleted the fix/azure-b2c branch September 29, 2021 21:43
@BenjaminWFox
Copy link
Contributor

Pulled the latest & it worked great on my end. Will keep you posted if I discover anything useful re: the profile images.

mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
* fix(providers): refactor AzureB2C provider

* chore(dev): add Azure B2C to the dev app

* chore(providers): remove unnecessary config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants