Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): make OAuth profile overrideable #2682

Merged
merged 3 commits into from
Sep 6, 2021
Merged

fix(ts): make OAuth profile overrideable #2682

merged 3 commits into from
Sep 6, 2021

Conversation

balazsorban44
Copy link
Member

Fixes #2681

@balazsorban44 balazsorban44 requested a review from ndom91 September 6, 2021 20:44
@github-actions github-actions bot added core Refers to `@auth/core` providers labels Sep 6, 2021
@balazsorban44 balazsorban44 temporarily deployed to Preview September 6, 2021 20:45 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 14.26%. Comparing base (419ffe7) to head (0a067a0).

Files with missing lines Patch % Lines
src/providers/facebook.ts 0.00% 2 Missing ⚠️
src/providers/google.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             beta    #2682   +/-   ##
=======================================
  Coverage   14.26%   14.26%           
=======================================
  Files          85       85           
  Lines        1339     1339           
  Branches      378      378           
=======================================
  Hits          191      191           
  Misses       1078     1078           
  Partials       70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balazsorban44 balazsorban44 mentioned this pull request Sep 6, 2021
Closed
@github-actions
Copy link

github-actions bot commented Sep 6, 2021 •
edited
Loading

🎉 Experimental release published on npm!

npm i next-auth@0.0.0-pr.2682.10a4ba14
yarn add next-auth@0.0.0-pr.2682.10a4ba14

@balazsorban44 balazsorban44 temporarily deployed to Preview September 6, 2021 21:00 Inactive
@balazsorban44 balazsorban44 temporarily deployed to Preview September 6, 2021 21:05 Inactive
ndom91
ndom91 approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balazsorban44 balazsorban44 merged commit 0989acc into beta Sep 6, 2021
@balazsorban44 balazsorban44 deleted the fix/oauth-profile-ts branch September 6, 2021 21:42
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
@mnphpexpert
fix(ts): make OAuth profile overrideable (nextauthjs#2682)
cf26778 
* fix(ts): make OAuth profile overrideable

* fix(ts): default to empty object

* fix(ts): use relative import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 ndom91 approved these changes

Assignees
No one assigned
Labels
core Refers to `@auth/core` providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balazsorban44 @codecov-commenter @ndom91