feat(providers): add WeChat #2519

zhuangya · 2021-08-13T10:06:31Z

Reasoning 💡

introduce WeChat OAuth 2.0 provider

Checklist 🧢

Documentation
Tests
Ready to be merged

Affected issues 🎟

vercel · 2021-08-13T10:06:35Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/FRNFV5uLmPLU4LmLFddiuvQDVsWh
✅ Preview: https://next-auth-git-fork-zhuangya-wechat-provider-nextauthjs.vercel.app

balazsorban44

Thank you for this PR! We are close to a new major release, so I kindly ask you to change the base of this PR from main to next. Unfortunately, there is a big chance for a few merge conflicts, so the easiest way is to probably to reopen this PR where you base your branch on our next branch to begin with. I am sorry for the inconvenience, this will hopefully not be required for long.

To comply with the new Provider API, I kindly ask you to incorporate my suggestions. I might have a few more when you have a PR against next, but I am happy to help you through this to be merged!

I would also like to ask, do you know how we could set up a test account on WeChat to add it to our basic sign-in test suite to ship this with more confidence?

Feel free to ask me anything

balazsorban44 · 2021-08-13T10:22:34Z

src/server/lib/oauth/client.js

+  } else if (provider.id === 'wechat') {
+    params.appid = provider.clientId || provider.appid
+    params.secret = provider.clientSecret;


Custom behavior in the core like this won't be supported in the upcoming major release. Read #2411 and the corresponding RFC #1846 for context and to see how you can mitigate this.

balazsorban44 · 2021-08-13T10:22:44Z

src/server/lib/oauth/client.js

+    // WeChat has different url params design
+    if (provider.id === 'wechat') {
+      const wechatProfileURL = new URL(url)
+
+      wechatProfileURL.searchParams.append('access_token', results.accessToken)
+      wechatProfileURL.searchParams.append('openid', results.openid)
+
+      url = wechatProfileURL.href
+    }


Custom behavior in the core like this won't be supported in the upcoming major release. Read #2411 and the corresponding RFC #1846 for context and to see how you can mitigate this.

balazsorban44 · 2021-08-13T10:24:10Z

src/providers/wechat.js

+        id: profile.openid,
+        nickname: profile.nickname,
+        avatar: profile.headimgurl


The upcoming version will require all built-in providers to return a unified output here by default, which is id, name, email, image, defaulting to null. Read #2411 and the corresponding RFC #1846 for context.

balazsorban44 · 2021-08-13T10:24:50Z

www/docs/providers/wechat.md

+## Documentation
+
+https://developers.weixin.qq.com/doc/offiaccount/en/OA_Web_Apps/Wechat_webpage_authorization.html
+


Please also add a Configuration section

balazsorban44 · 2021-08-13T10:25:10Z

src/providers/wechat.js

+    authorizationParams: {
+      appid: options.clientId
+    },
+    protection: "state",


Suggested change

protection: "state",

protection: ["state"],

zhuangya · 2021-08-13T11:27:49Z

Thank you for this PR! We are close to a new major release, so I kindly ask you to change the base of this PR from main to next. Unfortunately, there is a big chance for a few merge conflicts, so the easiest way is to probably to reopen this PR where you base your branch on our next branch to begin with. I am sorry for the inconvenience, this will hopefully not be required for long.

To comply with the new Provider API, I kindly ask you to incorporate my suggestions. I might have a few more when you have a PR against next, but I am happy to help you through this to be merged!

No worry, I'll take care of this.
I've already gone through your suggestions, and I'd like to read #2411 and #1846 first.

I would also like to ask, do you know how we could set up a test account on WeChat to add it to our basic sign-in test suite to ship this with more confidence?

not yet, but i think i can figure it out

Feel free to ask me anything

Thank you, it's very kind of you!

stale · 2021-10-12T12:25:54Z

Hi there! It looks like this issue hasn't had any activity for a while. It will be closed if no further activity occurs. If you think your issue is still relevant, feel free to comment on it to keep it open. (Read more at #912) Thanks!

stale · 2021-10-19T15:37:58Z

Hi there! It looks like this issue hasn't had any activity for a while. To keep things tidy, I am going to close this issue for now. If you think your issue is still relevant, just leave a comment and I will reopen it. (Read more at #912) Thanks!

jonidelv · 2022-08-31T01:03:50Z

I really need this 😿 is there any chance of this moving forward? Sorry, I'm not yet familiar with the code to help.

StarDxxx · 2022-10-19T15:45:21Z

we need wechat

GiantappMan · 2022-12-27T02:38:07Z

Please support WeChat, WeChat is a commonly used way in China

kulame · 2022-12-31T06:14:42Z

we need wechat., please support it !

zuohuadong · 2023-04-24T17:42:42Z

we need wechat., please support it !

sharkqwy · 2024-01-30T17:23:23Z

World's 18% users are on WeChat. It doesn't make sense to support all other smaller social providers while ignore it. Please add support for WeChatProvider

daniel548604106 · 2024-01-31T11:25:39Z

Please support wechat

vercel bot temporarily deployed to Preview August 13, 2021 10:06 Inactive

github-actions bot added core Refers to `@auth/core` providers labels Aug 13, 2021

zhuangya marked this pull request as ready for review August 13, 2021 10:08

zhuangya changed the title ~~WIP: feat(providers): add WeChat~~ feat(providers): add WeChat Aug 13, 2021

zhuangya force-pushed the wechat-provider branch from a93904b to 84ddade Compare August 13, 2021 10:14

vercel bot temporarily deployed to Preview August 13, 2021 10:14 Inactive

github-actions bot added the docs Relates to documentation label Aug 13, 2021

feat(providers): add WeChat

a4cb4aa

zhuangya force-pushed the wechat-provider branch from 84ddade to a4cb4aa Compare August 13, 2021 10:15

vercel bot temporarily deployed to Preview August 13, 2021 10:15 Inactive

balazsorban44 requested changes Aug 13, 2021

View reviewed changes

fix: add missing provider type

18cac74

zhuangya requested a review from ubbe-xyz as a code owner August 13, 2021 10:41

vercel bot temporarily deployed to Preview August 13, 2021 10:41 Inactive

github-actions bot added the TypeScript Issues relating to TypeScript label Aug 13, 2021

stale bot added the stale Did not receive any activity for 60 days label Oct 12, 2021

stale bot closed this Oct 19, 2021

zhuangya deleted the wechat-provider branch October 31, 2022 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(providers): add WeChat #2519

feat(providers): add WeChat #2519

zhuangya commented Aug 13, 2021 •

edited

Loading

vercel bot commented Aug 13, 2021 •

edited

Loading

balazsorban44 left a comment •

edited

Loading

balazsorban44 Aug 13, 2021 •

edited

Loading

balazsorban44 Aug 13, 2021 •

edited

Loading

balazsorban44 Aug 13, 2021

balazsorban44 Aug 13, 2021

balazsorban44 Aug 13, 2021

zhuangya commented Aug 13, 2021

stale bot commented Oct 12, 2021

stale bot commented Oct 19, 2021

jonidelv commented Aug 31, 2022

StarDxxx commented Oct 19, 2022

GiantappMan commented Dec 27, 2022

kulame commented Dec 31, 2022

zuohuadong commented Apr 24, 2023

sharkqwy commented Jan 30, 2024

daniel548604106 commented Jan 31, 2024

		## Documentation

		https://developers.weixin.qq.com/doc/offiaccount/en/OA_Web_Apps/Wechat_webpage_authorization.html

feat(providers): add WeChat #2519

feat(providers): add WeChat #2519

Conversation

zhuangya commented Aug 13, 2021 • edited Loading

Reasoning 💡

Checklist 🧢

Affected issues 🎟

vercel bot commented Aug 13, 2021 • edited Loading

balazsorban44 left a comment • edited Loading

Choose a reason for hiding this comment

balazsorban44 Aug 13, 2021 • edited Loading

Choose a reason for hiding this comment

balazsorban44 Aug 13, 2021 • edited Loading

Choose a reason for hiding this comment

balazsorban44 Aug 13, 2021

Choose a reason for hiding this comment

balazsorban44 Aug 13, 2021

Choose a reason for hiding this comment

balazsorban44 Aug 13, 2021

Choose a reason for hiding this comment

zhuangya commented Aug 13, 2021

stale bot commented Oct 12, 2021

stale bot commented Oct 19, 2021

jonidelv commented Aug 31, 2022

StarDxxx commented Oct 19, 2022

GiantappMan commented Dec 27, 2022

kulame commented Dec 31, 2022

zuohuadong commented Apr 24, 2023

sharkqwy commented Jan 30, 2024

daniel548604106 commented Jan 31, 2024

zhuangya commented Aug 13, 2021 •

edited

Loading

vercel bot commented Aug 13, 2021 •

edited

Loading

balazsorban44 left a comment •

edited

Loading

balazsorban44 Aug 13, 2021 •

edited

Loading

balazsorban44 Aug 13, 2021 •

edited

Loading