-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(client): fully cover client module #2295
Conversation
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/nextauthjs/next-auth/CJmTp4yDwjdj7KQTqzL3xFmSumvD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
I didn't follow the thread 100%, on mobile currently, but I saw your TODO, just curious why can't we clean __NEXTAUTH between test runs?
Small comment I noticed that don't see why those are generated from the .ts test files at all, they are just tests, if not possible to not generate them, should we just delete after a test run? |
Codecov Report
@@ Coverage Diff @@
## next #2295 +/- ##
==========================================
+ Coverage 11.48% 13.97% +2.49%
==========================================
Files 85 85
Lines 1324 1324
Branches 379 378 -1
==========================================
+ Hits 152 185 +33
+ Misses 975 950 -25
+ Partials 197 189 -8
Continue to review full report at Codecov.
|
85663ba
to
34ffda9
Compare
staleTime
work
@theobr has pointed out to me that @lluia After reading the docs, would you agree?: |
@balazsorban44 thinking twice, you're right, I believe most clients are looking for the behaviour offered by |
β’ remove `staleTime` β’ finish client tests
e0e78f0
to
340268b
Compare
staleTime
workstaleTime
β’ Bring back `staleTime` (remove it on an up-coming PR) β’ Refine failed session flow
staleTime
Contains: * test(client-provider): fix flaky test * wip * test(client-provider): verify more use-cases * test(client): programmatic session refetch * test(client): further coverage * test(client): `stateTime` + `refetchInterval` * refactor(client): test insights * refactor: unused variable * chore: revert `package-lock.json` to v2 * refactor: pair-review suggestions
Reasoning π‘
Final tests for
<SessionProvider />
anduseSession()
ππ»ββοΈChecklist π§’
DocumentationReady to be mergedAffected issues π
None