Step 2 - Blackjack #833
Open
Step 2 - Blackjack #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrong
commented
Apr 15, 2025
| @@ -151,7 +149,19 @@ class DslTest { | |||
| fun build(): Skills = Skills(soft, hard) | |||
| } | |||
|
|
|||
| data class Person(val name: String, val company: String?, val skills: Skills?, val languages: Map<String, Int>?) | |||
| class LanguageBuilder { | |||
There was a problem hiding this comment.
Extracted LanguageBuilder and it makes easy to understand and readable!
There was a problem hiding this comment.
I forgot to add ktlint pre-check! I added it and did formatting with ktlint 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Brie, It was really nice to see you in person in Berlin! 😆
Came back with second step of blackjack and please take a look.
I'm looking forward your comment.
Thank you and have a nice day!