Improved helper function getModelName() #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not work in case an extension used in config.xml:
<models>
<mygroupname>
<class>MyPackage_MyExtension_Model</class>
<mygroupname>
</models>
Because then the class guessed by getModelName($product) is:
`myextension/product` while it should be `mygroupname/product`.
I made the function check if the guess is a valid model. If not: the right value is quite hard to look up, so I decided to return `MyPackage_MyExtension_Model_Product` in this example.
|
@miguelbalparda Did you get a chance to look at this PR? |
|
@jeroenvermeulen yes we are looking to merge this no later than this week. Thank you for your contribution! |
miguelbalparda
added a commit
that referenced
this pull request
Dec 30, 2015
Improved helper function getModelName()
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
Mage::helper('turpentine/data')->getModelName($product);did not work in case an extension used in config.xml:Because then the class guessed by
getModelName($product)wasmyextension/productwhile it should bemygroupname/product.I made the function check if the guessed value is a valid model name.
If not valid: the right value is quite hard to look up, so I decided to return the full class name,
MyPackage_MyExtension_Model_Productin this example.