Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-0.6.5 ignores backend settings #904

Closed
BarryCarlyon opened this issue Aug 28, 2015 · 0 comments
Closed

release-0.6.5 ignores backend settings #904

BarryCarlyon opened this issue Aug 28, 2015 · 0 comments
Assignees
Labels

Comments

@BarryCarlyon
Copy link

I just upgraded to 0.6.5 release.

When the settings set like so:

configuration___system___magento_admin_-fred_aldous-_fred_aldous

The configuration became:

director default round-robin {
{
.backend = {
.host = "127.0.0.1";
.port = "8080";
.first_byte_timeout = 300s;
.between_bytes_timeout = 300s;
}
}
}
director admin round-robin {
{
.backend = {
.host = "127.0.0.1";
.port = "8080";
.first_byte_timeout = 21600s;
.between_bytes_timeout = 21600s;
} 
}
}

Ignoring my settings and thus knocking the site offline.

I'm tracing the problem now, but just wanted to start a Issue thread

BarryCarlyon pushed a commit to BarryCarlyon/magento-turpentine that referenced this issue Aug 28, 2015
The code here is doing a boolean check but the setting is saved as a string (no, yes or yes_admin)
This was referenced Aug 28, 2015
BarryCarlyon pushed a commit to BarryCarlyon/magento-turpentine that referenced this issue Aug 28, 2015
The code here is doing a boolean check but the setting is saved as a string (no, yes or yes_admin)
As per nexcess#904 this fixes the config geneator
@miguelbalparda miguelbalparda self-assigned this Aug 28, 2015
miguelbalparda added a commit that referenced this issue Aug 28, 2015
Fix for: ignores backend settings #904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants