-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy issue for product_list_toolbar + ESI Processing not enabled errors #1097
Comments
@pascaladriaansen have you tried using the ajax method for the For problem #2 - can you tell which block would normally be rendered here by looking at the HTML generated in that spot when bypassing varnish? I suspect the problems you're having with Also - for both of these issues, have you examined the logs for any hints as to what might be going wrong? |
@aricwatson I have tried the ajax method for the File
And this is the _getProductCollection method:
It seems that it needs the current_layer registry key (I logged the $layer variable to my system.log and it ended up being empty) to get the product collection from. So what I tried to do was add the current_layer registry key to my ESI settings in the layout.xml:
Unfortunately, this results in the following exception: I have no idea where to look for a solution regarding this exception. Any ideas? edit: Ok, forget the above stuff about the |
That sounds likely - what are the methods that are being overridden? |
Hi, After enable turpentine with varnish header and footer are missing with some error. Please advise me. We used Sm market theme. PLease advise me. |
@dartsuresh Turpentine is not a plug and play module. You might need to do some changes to your theme to make the module work. Have you checked the wiki? |
Sorry for this, Am new in magento and varnish. Can yyou please provide the Wiki url where can i change the theme work with? |
Yes I did the same steps here. How to know what are the changes we need to do in theme.? Pleae advise. |
@dartsuresh that will depend on your theme's structure. |
I have the same issue. $this->setAlias( right before return true; |
Closing this for now. @magefan if you're still having problems with filtering, feel free to open a new issue with specifics. |
Hi!
I'm having some issues with setting up ESI cache policies resulting in ESI Processing not enabled errors.
1. Product list toolbar
Because we have different prices / catalog rules for different customer groups, I have set the following policy for the
product_list
block:This successfully shows the correct prices to each customer group. Unfortunately, this policy renders the
product_list_toolbar
unusable. Any action like sorting or changing the grid/list mode links to an incorrect URL. For example, the grid mode button links to/?mode=grid
(note that the current category path is not even in this URL). We're using Manadev Layered Navigation, so it should link to something like/my-current-category/mode/grid
.After setting an ESI policy for the
product_list_toolbar
block that setsaccess
toprivate
and attl
of0
so it won't be cached, aESI Processing is not enabled
message is shown.I found out that a PHP fatal error occurs when the
product_list_toolbar
block tries to render:PHP message: PHP Fatal error: Call to a member function getSize() on a non-object in /data/web/package/app/design/frontend/mytheme/mypackage/template/catalog/product/list/toolbar.phtml on line 34
Line 34 contains this:
$this->getCollection()->getSize()
. So, for some reason,$this->getCollection()
doesn't return a valid collection object. I have tried to add some registry keys to theproduct_list_toolbar
block's ESI policy, because it seems like it needs thecurrent_category
,current_product
andcurrent_layer
registry keys to know how the URLs should be generated:Unfortunately, this doesn't change a thing. I have tried everything I could think of but nothing worked. Do you have any idea how I should fix this?
2. Can't find block(s) showing ESI Processing not enabled message(s)
Another problem I am facing is that on the same page, just above the
product_list_toolbar
block, is anotherESI Processing not enabled
message. I have tried to comment out any $this->getChildHtml() on that page to find out which block is rendering this error message, but no matter which blocks I comment out, the message still shows.How can I determine which block is causing this issue? I have already tried Block logging and enabling Debug Info, but I can't find anything related to the ESI Processing not enabled message.
If it helps, this is what the source code looks like:
![Screenshot](https://camo.githubusercontent.com/a52aa30195bec4e04da8841e83267cacb5524ea3e3be2df07c83b81ad8faf1bf/68747470733a2f2f7777772e64726f70626f782e636f6d2f732f7364776873383369727963346e74382f53637265656e73686f74253230323031362d30322d313025323031302e30332e35372e706e673f7261773d31)
I noticed the
<!-- ESI START [product_list] -->
seems to be missing.Thanks! :)
The text was updated successfully, but these errors were encountered: