-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle filter_current_dashboard on update #1662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbazhlekova
force-pushed
the
fix-filter-current-dashboard
branch
from
March 4, 2022 23:16
1ed5d57
to
119aa55
Compare
mbazhlekova
force-pushed
the
fix-filter-current-dashboard
branch
from
March 4, 2022 23:18
119aa55
to
566eff7
Compare
mbazhlekova
changed the title
WIP handle filter_current_dashboard on read
Handle filter_current_dashboard on update
Mar 4, 2022
looks good.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles filter_current_dashboard properly on dashboard update. Before it was only handled on dashboard create.
Fixes #1494
Type of change
Checklist:
How to test this change?
Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc
terraform plan
andterraform apply
Filter Example
widget and verify thatFilter the current dashboard
is selectedfilter_current_dashboard
tofalse
terraform plan
andterraform apply
againFilter Example
widget and verify thatFilter the current dashboard
is no longer selected