feat: Added python 3.12 #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python 3.12 is supported from aws and also the layers in nr already exist
|
|
|
Thank you, @Engerim ! This looks good! Would you be willing to rebase against main so that test fixtures are updated? |
|
@mrickard I checked it my branch is up to date, the error is in codecove for uploading the coverage report |
mrickard
approved these changes
Apr 29, 2024
|
Thank you, @Engerim ! I'm going to merge this and we'll work out the test coverage issue on our end. Thank you! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python 3.12 is supported from aws and also the layers in nr already exist