fix: Migrate CircleCI to GHA #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blish Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
bizob2828
requested changes
Mar 15, 2024
Signed-off-by: mrickard <maurice@mauricerickard.com>
mrickard
force-pushed
the
NR-248539/migrate-to-gha
branch
from
a2513e6 to
83130b8
Compare
Signed-off-by: mrickard <maurice@mauricerickard.com>
mrickard
force-pushed
the
NR-248539/migrate-to-gha
branch
from
83130b8 to
c51fb96
Compare
bizob2828
requested changes
Mar 15, 2024
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 35.14% 35.14%
=======================================
Files 4 4
Lines 552 552
Branches 149 149
=======================================
Hits 194 194
Misses 329 329
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mrickard <maurice@mauricerickard.com>
Signed-off-by: mrickard <maurice@mauricerickard.com>
bizob2828
approved these changes
Mar 18, 2024
|
@bizob2828 Thank you! Yes--I have to remove the CircleCI checks, and then ensure the GHA checks after I merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitHub Actions workflows for validate (lint, test), and publish.
Closes #411
Closes #408
Closes NR-248539