Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility startup details added #18

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Utility startup details added #18

merged 3 commits into from
Dec 14, 2023

Conversation

nijugeorge173
Copy link
Contributor

@nijugeorge173 nijugeorge173 commented Nov 24, 2023 •
edited
Loading

Description

Following are details of PR :

  1. Added documentation detailing the file location for config.yml ( ./configs/config.yml)
  2. Environment variable for license key ('NEW_RELIC_LICENSE_KEY') should be added during setup. When missing the utility fails with error that license key needs to be of length 40. After adding the environment variable the utility starts up properly.

sdewitt-newrelic
sdewitt-newrelic requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@sdewitt-newrelic sdewitt-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nijugeorge173 sorry about that, though I had clicked submit review already but missed that step. Please see requested changes.

@jbeveland27 jbeveland27 merged commit 5d9a32f into newrelic:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdewitt-newrelic sdewitt-newrelic sdewitt-newrelic requested changes

@jbeveland27 jbeveland27 jbeveland27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nijugeorge173 @jbeveland27 @sdewitt-newrelic