feat: Added http timeslice metrics from otel #2924
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
==========================================
- Coverage 97.42% 97.38% -0.05%
==========================================
Files 316 316
Lines 48383 48406 +23
==========================================
+ Hits 47139 47140 +1
- Misses 1244 1266 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| assert.equal(attrs['url.scheme'], 'http') | ||
| assert.equal(attrs.nr_exclusive_duration_millis, duration) | ||
|
|
||
| const unscopedMetrics = tx.metrics.unscoped |
There was a problem hiding this comment.
It's not clear to me if there should be any scoped metrics. When I step through, there are not any.
There was a problem hiding this comment.
yes there are a lot of metrics getting created, some aren't complete because it's not propagating context from upstream if it exists(which I will add in my ticket) but here are some that need asserted:
Apdex, Apdex/<partialName> which is currently null(I have fixed this), HttpDispatcher, WebTransactionTotalTime, WebTransactionTotalTime/(i have fixed in my PR)
There was a problem hiding this comment.
Those are present in the unscoped metrics. I can add assertions for them. But I get zero metrics in tx.metrics.scoped.
There was a problem hiding this comment.
ah sorry, yea there are no scoped metrics in this recorder. you can tell by looking at the recorder, the 2nd arg would be the scope and all are set to null
| assert.equal(attrs['url.scheme'], 'http') | ||
| assert.equal(attrs.nr_exclusive_duration_millis, duration) | ||
|
|
||
| const unscopedMetrics = tx.metrics.unscoped |
There was a problem hiding this comment.
yes there are a lot of metrics getting created, some aren't complete because it's not propagating context from upstream if it exists(which I will add in my ticket) but here are some that need asserted:
Apdex, Apdex/<partialName> which is currently null(I have fixed this), HttpDispatcher, WebTransactionTotalTime, WebTransactionTotalTime/(i have fixed in my PR)
jsumners-nr
force-pushed
the
issue-2655
branch
from
f6dee73 to
7017def
Compare
jsumners-nr
force-pushed
the
issue-2655
branch
from
7017def to
98d57a4
Compare
This PR resolved #2655.