fix: Fixed transaction-shim to properly create new transactions when the existing transaction is not active #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the existing transaction is not active
mrickard
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
+ Coverage 90.26% 97.36% +7.09%
==========================================
Files 289 309 +20
Lines 45807 47408 +1601
==========================================
+ Hits 41347 46157 +4810
+ Misses 4460 1251 -3209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like warm starts of lambdas leak async context in Node.js A regression was introduced here. Previously before wrapping a call in a transaction it checked for an active transaction, this changed and only checked for a transaction, not that it was active. For some reason during warm invocations of lambda, the Node.js async context(which we just leverage AsyncLocalStorage) is leaking across runs.
How to Test
I added some unit tests around transaction-shim. Also we manually tested with a patched layer in lambda and there were 8 requests made and all 8 had telemetry.
Related Issues
Closes #2910