Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updated security agent workflow to use large runners when available #2270

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

bizob2828
Copy link
Member

Description

We've had flappy nightly runs with versioned tests with security agent and memcached tests.

 # Subtest: captures datastore instance attributes with multiple hosts
        # Subtest: separate gets
            not ok 1 - timeout!
              ---
              expired: memcached instrumentation
              test: separate gets
              ...
            
            1..1
            # failed 1 test
        not ok 1 - separate gets # time=36.22ms
        
        # Subtest: multi-get
            not ok 1 - Maximum call stack size exceeded
              ---
              stack: |
                Client.stubbedCommand (memcached.tap.js:654:9)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
                Client.stubbedCommand (memcached.tap.js:654:21)
              at:
                line: 654
                column: 9
                file: memcached.tap.js
                function: Client.stubbedCommand
              type: RangeError
              tapCaught: testFunctionThrow
              test: multi-get
              source: |2
                        /* eslint-enable no-unused-vars */
                        origCommand.call(this, queryCompiler, realServer)
                --------^

I suspect it's the limitations of running with the default runner. This PR uses the larger runner.

@bizob2828 bizob2828 merged commit 761fcd5 into newrelic:main Jun 12, 2024
17 checks passed
@bizob2828 bizob2828 deleted the use-large-runner branch June 12, 2024 16:13
@bizob2828 bizob2828 added the dev:automation Indicates CI automation label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:automation Indicates CI automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants