DD templating: conditionally invoke requires #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per #2844, don't perform `require_relative` on content that won't be used unless all dependency detection checks succeed
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
Comment on lines
17
to
20
| require_relative '<%= @snake_name.downcase %>/instrumentation' | ||
| require_relative '<%= @snake_name.downcase %>/chain' | ||
| require_relative '<%= @snake_name.downcase %>/prepend' | ||
|
|
There was a problem hiding this comment.
Thoughts on going a step further... to require the instrumentation file here, and the chain and/or prepend files within the condition below?
require_relative '<%= @snake_name.downcase %>/instrumentation'
if use_prepend?
require_relative '<%= @snake_name.downcase %>/prepend'
prepend_instrument <%= @class_name %>, NewRelic::Agent::Instrumentation::<%= @class_name %>::Prepend
else
require_relative '<%= @snake_name.downcase %>/chain'
chain_instrument NewRelic::Agent::Instrumentation::<%= @class_name %>::Chain
end
There was a problem hiding this comment.
Sure, addressed with 1c6d8a3.
when chaining or prepending, only bring in the appropriate chain or prepend code
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #2844, don't perform
require_relativeon content that won't be used unless all dependency detection checks succeed