Create helper to access Bundler.rubygems specs #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
commented
Oct 10, 2024
Bundler version 2.5.12 deprecated all_specs and added installed_specs. To support newer Bundler versions, try to use installed_specs first, then fall back to all_specs. All callers expect this to be an array, so return an array if Bundler isn't defined. This consolidates the way the rubygems specs are accessed across the multiple places we use them.
kaylareopelle
changed the title
kaylareopelle
commented
Oct 14, 2024
| end | ||
|
|
||
| def test_rubygems_specs_works_with_all_specs_when_installed_specs_is_absent | ||
| Bundler.rubygems.stub(:respond_to?, nil) do |
There was a problem hiding this comment.
I don't understand why, but Rubies 2.6 and below don't like the third argument for a stub in this scenario. However, they're fine with it in the test above. 🤷
There was a problem hiding this comment.
My guess is that the older Rubies are given an older Minitest. Wanting to use 3 arguments was the primary reason for the introduction of our skip_unless_minitest5_or_above helper.
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
SimpleCov Report
|
fallwith
approved these changes
Oct 15, 2024
| end | ||
|
|
||
| def test_rubygems_specs_works_with_all_specs_when_installed_specs_is_absent | ||
| Bundler.rubygems.stub(:respond_to?, nil) do |
There was a problem hiding this comment.
My guess is that the older Rubies are given an older Minitest. Wanting to use 3 arguments was the primary reason for the introduction of our skip_unless_minitest5_or_above helper.
patrickarnett
pushed a commit
to patrickarnett/newrelic-ruby-agent
that referenced
this pull request
Oct 17, 2024
Create helper to access Bundler.rubygems specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug reported in #2885 to protect against scenarios where the version of Bundler used does not support
Bundler.rubygems.installed_specsand needs to useBundler.rubygems.all_specsto determine whether the third-party gem,newrelic-grapeis installed in the environment.Resolves #2885