ServerlessHandler: error handling for URI parsing #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address issues with the recent serverless enhancements discovered through local dev testing with the Node.js tool 'serverless': - Don't append a port value to a URI string that already contains one - If the URI string construction or parsing fails for any reason, log an error and return `nil` so that further processing of the function invocation is not impacted These issues are thought to only be reproducible outside of AWS, but it's good to be proactive with a bit of extra caution.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
simply say "without AWS" to refer to local testing
kaylareopelle
approved these changes
Aug 19, 2024
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issues with the recent serverless enhancements discovered through local dev testing with the Node.js tool 'serverless':
nilso that further processing of the function invocation is not impactedThese issues are thought to only be reproducible outside of AWS, but it's good to be proactive with a bit of extra caution.