JRuby fix for concurrency issue with manager cache #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration manager's alteration of its internal cache hash to preserve previously dynamically defined values has been known to cause problems with JRuby given its concurrent access to the hash object. We have used `synchronize` and `Hash#dup` fixes previously, but still have reports of issues. When it comes down to it, the alteration of the hash was only added and still only needed for use by the security agent. So let's just not even attempt to alter the hash if JRuby is in play but the security agent is not.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
kaylareopelle
previously approved these changes
Aug 9, 2024
|
@fallwith - Should a changelog entry be added for this? |
changelog entry for JRuby concurrency fix
kaylareopelle
approved these changes
Aug 9, 2024
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration manager's alteration of its internal cache hash to preserve previously dynamically defined values has been known to cause problems with JRuby given its concurrent access to the hash object. We have used
synchronizeandHash#dupfixes previously, but still have reports of issues.When it comes down to it, the alteration of the hash was only added and still only needed for use by the security agent. So let's just not even attempt to alter the hash if JRuby is in play but the security agent is not.