Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grape padrino framework detection #2789

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Grape padrino framework detection #2789

merged 5 commits into from
Aug 5, 2024

Conversation

prateeksen
Copy link
Contributor

  • Grape and Padrino framework detection for environment report.
    This information is required for newrelic_security to show on UI whether application is supported or not.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Jul 30, 2024
@prateeksen prateeksen linked an issue Jul 30, 2024 that may be closed by this pull request
Fix padrino and grape framework detection #2777
Closed
@fallwith fallwith removed the community To tag external issues and PRs submitted by the community label Jul 30, 2024
kaylareopelle
kaylareopelle requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience while I ran some tests with this change! I have a few suggestions to keep the experience more consistent for Padrino and Grape customers.

lib/new_relic/control/frameworks/padrino.rb Outdated Show resolved Hide resolved
lib/new_relic/control/frameworks/grape.rb Outdated Show resolved Hide resolved
prateeksen and others added 3 commits August 5, 2024 10:15
@prateeksen @kaylareopelle
Update lib/new_relic/control/frameworks/padrino.rb
c99a9a3 
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
@prateeksen @kaylareopelle
Update lib/new_relic/control/frameworks/grape.rb
051ec8e 
Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>
@prateeksen
inherit padrino from sinatra instead of ruby framework
2ba1ef3
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

SimpleCov Report

Coverage Threshold
Line 93.88% 93%
Branch 70.62% 50%

@prateeksen
Copy link
Contributor Author

Hi @kaylareopelle I have accepted and added your suggestions.

@kaylareopelle kaylareopelle mentioned this pull request Aug 5, 2024
Merged
@kaylareopelle kaylareopelle merged commit 07b52cf into dev Aug 5, 2024
32 checks passed
@kaylareopelle kaylareopelle deleted the grape-padrino-framework-detection branch August 5, 2024 18:16
@kaylareopelle kaylareopelle mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallwith fallwith fallwith approved these changes

@tannalynn tannalynn tannalynn approved these changes

@hannahramadan hannahramadan hannahramadan approved these changes

@kaylareopelle kaylareopelle kaylareopelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix padrino and grape framework detection
5 participants
@prateeksen @fallwith @tannalynn @hannahramadan @kaylareopelle