include additional AC topics in Rails subscription #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When subscribing to Action Controller topics for Rails notifications, include 4 new topics in the subscription regex: - `exist_fragment?` - `expire_fragment` - `read_fragment` - `write_fragment`
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
|
|
||
| # have to double escape period because its going from string -> regex | ||
| NewRelic::Agent::Instrumentation::ActionControllerOtherSubscriber \ | ||
| .subscribe(Regexp.new("^(#{subs.join('|')})\\.action_controller$")) | ||
| .subscribe(Regexp.new("^(?:#{subs.join('|')})\\.action_controller$")) |
There was a problem hiding this comment.
What is the addition of ?: doing as a non-regex pro?
There was a problem hiding this comment.
By default, wrapping part of the pattern in parens will cause the part of the match to be captured. By using (?:) instead of (), I'm telling both the parser and the future human reviewer that we don't actually intend to do any capturing with this regex and simply want to use the parens for grouping.
kaylareopelle
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscribing to Action Controller topics for Rails notifications, include 4 new topics in the subscription regex:
exist_fragment?expire_fragmentread_fragmentwrite_fragment