Add new span attributes for bunny instrumentation #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
hannahramadan
previously approved these changes
Jul 3, 2024
fallwith
reviewed
Jul 3, 2024
kaylareopelle
previously approved these changes
Jul 3, 2024
There was a problem hiding this comment.
This looks good to me! I'm so glad the testing stuff got figured out!
If you wanted to, the SpanEventPrimitive class has constants you could use for the strings 'server.address' and 'server.port', but it might just be easier to read the string within the code. Whatever you think is best!
fallwith
approved these changes
Jul 3, 2024
SimpleCov Report
|
tannalynn
dismissed stale reviews from kaylareopelle and hannahramadan
via
1827a7a
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new attributes to consume and produce spans created in our bunny instrumentation.