Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace <DoNotTranslate> with <DNT> #2734

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Replace <DoNotTranslate> with <DNT> #2734

merged 2 commits into from
Jun 28, 2024

Conversation

hannahramadan
Copy link
Contributor

The docs team is replacing <DoNotTranslate> with <DNT>. We need to update this file to ensure we remain compatiable with docs parsing.

@hannahramadan hannahramadan marked this pull request as ready for review June 27, 2024 22:15
fallwith
fallwith approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@fallwith fallwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNT! https://www.youtube.com/watch?v=NhsK5WExrnE

@github-actions GitHub Actions
Copy link

SimpleCov Report

Coverage Threshold
Line 93.76% 93%
Branch 70.81% 50%

kaylareopelle
kaylareopelle approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think we might want to make sure the docs team knows we're removing the <DoNotTranslate> tag from that error_collector line, just in case they know something we don't about its importance.

@hannahramadan
Copy link
Contributor Author

hannahramadan commented Jun 27, 2024 •
edited
Loading

Thank you!

I think we might want to make sure the docs team knows we're removing the <DoNotTranslate> tag from that error_collector line, just in case they know something we don't about its importance.

Good shout! I'll check with them before merging ⚡️

Edit: docs confirmed that tag around code is redundant.

@hannahramadan hannahramadan merged commit 2628f8e into dev Jun 28, 2024
32 checks passed
@hannahramadan hannahramadan deleted the update_translate_tags branch June 28, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallwith fallwith fallwith approved these changes

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahramadan @fallwith @kaylareopelle