Stripe: do not include path ids in metric names #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When naming Stripe metrics, include only the first two (API version and category) portions of the path and not the id. Continue to start the metric name with "Stripe" and end it with the method (ex: "get"). This will prevent metric name exhaustion resulting from regular Stripe usage. Given a 'get' request performed against a path of '/v1/payment_methods/pm_8675309', the metric name will now be 'Stripe/v1/payment_methods/get'. resolves #2654 resolves #2709
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
tannalynn
reviewed
Jun 13, 2024
hannahramadan
approved these changes
Jun 13, 2024
This was referenced Jun 13, 2024
List the Stripe bugfix (PR 2716) in the changelog
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When naming Stripe metrics, include only the first two (API version and category) portions of the path and not the id. Continue to start the metric name with "Stripe" and end it with the method (ex: "get"). This will prevent metric name exhaustion resulting from regular Stripe usage.
Given a 'get' request performed against a path of
'/v1/payment_methods/pm_8675309', the metric name will now be 'Stripe/v1/payment_methods/get'.
resolves #2654
resolves #2709