lib/bootstrap.rb -> lib/boot/strap.rb #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not put any Ruby files in the root of `lib/` that do not match the gem name, or Ruby lib path based issues can arise with other gems. In this case, move `lib/bootstrap.rb` to `lib/boot/strap.rb` to avoid colliding with `require 'bootstrap'` calls intended to be received by the `bootstrap` gem. - For bootstrapping, do not ever perform `exit`. Instead, simply use `raise/rescue` for control flow. As a result, any future unintended loading of the bootstrapping will simply `warn` and return instead of causing the Ruby runtime to exit.
changelog updated for bug 2675
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
hannahramadan
approved these changes
Jun 3, 2024
kaylareopelle
approved these changes
Jun 3, 2024
tannalynn
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/that do not match thegem name, or Ruby lib path based issues can arise with other gems.
In this case, move
lib/bootstrap.rbtolib/boot/strap.rbto avoidcolliding with
require 'bootstrap'calls intended to be received bythe
bootstrapgem.exit. Instead, simply useraise/rescuefor control flow. As a result, any future unintendedloading of the bootstrapping will simply
warnand return instead ofcausing the Ruby runtime to exit.
resolves #2675