ActiveSupport notifications: allowlist event names #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new :'instrumentation.active_support_notifications.active_support_events' configuration parameter to permit a user defined allowlist of Active Support notifications event names for the agent to subscribe to that are related to the Active Support library itself. Event names that are not included on the list will be ignored by the agent.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
don't attempt to subscribe to notifications based on an empty list
Now that the constant based hash is needed by default_source.rb, make sure its class can successfully require the notifications class
lib/new_relic/agent/instrumentation/active_support_subscriber.rb
Outdated
Show resolved
Hide resolved
put in a temporary Ruby version <= 2.4 path for older Rubies that don't support `String#delete_prefix` and silence the RuboCop warning within the Ruby <= 2.4 specific path.
reference the Active Support specific event names lists for caching and messages in the documentation for the relevant configuration parameter
Reference the edge content with the fixed anchors Co-authored-by: Kayla Reopelle (she/her) <87386821+kaylareopelle@users.noreply.github.com>
|
Closing for now. Please leave the branch alone. Tracking future developments with #2685. |
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new :'instrumentation.active_support_notifications.active_support_events' configuration parameter to permit a user defined allowlist of Active Support notifications event names for the agent to subscribe to that are related to the Active Support library itself.
Event names that are not included on the list will be ignored by the agent